Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dialog] Only close the dialog if the click outside originated outside #246

Merged
merged 1 commit into from
Oct 3, 2019
Merged

[dialog] Only close the dialog if the click outside originated outside #246

merged 1 commit into from
Oct 3, 2019

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Aug 1, 2019

This PR covers the same ground as #239, but uses the Component² abstraction for refs.

@venikx
Copy link

venikx commented Aug 1, 2019

I’ll close #239 in favor of this one ;)

@venikx venikx mentioned this pull request Aug 1, 2019
Closed
@coreylight
Copy link

Can this be merged @ryanflorence ?

@chaance chaance merged commit 7dc3dc4 into reach:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmcw @venikx @coreylight @chaance